-
Notifications
You must be signed in to change notification settings - Fork 4.6k
cache cleanup #3491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache cleanup #3491
Conversation
Co-authored-by: Eldad A. Fux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few comments.
…cache-cleanup � Conflicts: � composer.json � composer.lock
@@ -72,6 +72,7 @@ OPEN_RUNTIMES_NETWORK=appwrite_runtimes | |||
_APP_EXECUTOR_SECRET=your-secret-key | |||
_APP_EXECUTOR_HOST=http://appwrite-executor/v1 | |||
_APP_MAINTENANCE_INTERVAL=86400 | |||
_APP_MAINTENANCE_RETENTION_CACHE=2592000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include this variable in variables.php and compose.phtml
https://github.com/appwrite/appwrite/blob/master/app/config/variables.php
https://github.com/appwrite/appwrite/blob/master/app/views/install/compose.phtml
], | ||
[ | ||
'$id' => 'accessedAt', | ||
'type' => Database::VAR_INTEGER, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date time changes are required here... Reminder to update the datatype, add filter after the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the last set of comments
What does this PR do?