Skip to content

Conversation

shimonewman
Copy link
Contributor

@shimonewman shimonewman commented Jul 3, 2022

What does this PR do?

  1. Handling cache files logic in a central place (app::init(), app::shutdown()).
  2. Purging outdated cache files via deletes worker.

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few comments.

@@ -72,6 +72,7 @@ OPEN_RUNTIMES_NETWORK=appwrite_runtimes
_APP_EXECUTOR_SECRET=your-secret-key
_APP_EXECUTOR_HOST=http://appwrite-executor/v1
_APP_MAINTENANCE_INTERVAL=86400
_APP_MAINTENANCE_RETENTION_CACHE=2592000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

],
[
'$id' => 'accessedAt',
'type' => Database::VAR_INTEGER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date time changes are required here... Reminder to update the datatype, add filter after the merge.

Copy link
Contributor

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the last set of comments

@eldadfux eldadfux merged commit 837336e into 0.16.x Aug 17, 2022
@shimonewman shimonewman deleted the feat-file-cache-cleanup branch September 4, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants