-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
ci: Add. external link checker #6424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! This PR aims to address issue #6385. |
Eomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link to a test run of this GHA?
Not sure if this is exactly what you meant, but it’s already running in this PR. Here’s the link: |
|
Ok, I checked the various PRs to solve this task, but I think the #6386 should land:
Thanks for taking care of the task 🙏🏼 |
Here’s why I used these parameters (.github/workflows/links-check.yml):
--accept 200,403
We accept 403 because sites like Medium, npmjs, and Twitter/X block bots/scrapers and commonly return a 403 even when the link is valid. Since these cases are rare in .md files, accepting 403 avoids false positives without affecting the usefulness of the check.
--max-concurrency 5
Limiting concurrency is necessary to avoid services like GitHub returning HTTP 429 (Too Many Requests) for pages that are otherwise accessible. Using 5 threads is enough, it prevents hitting rate limits while still keeping the link check reasonably fast.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct