Open
Conversation
reidn3r
changed the title
github-actions
bot
added
the
documentation
Contributor
Author
|
Hi! This PR aims to address issue #6385. |
Contributor
Author
Eomm
reviewed
Jan 17, 2026
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
Do you have a link to a test run of this GHA?
4 tasks
Contributor
Author
Not sure if this is exactly what you meant, but it’s already running in this PR. Here’s the link: |
Member
|
Ok, I checked the various PRs to solve this task, but I think the #6386 should land:
Thanks for taking care of the task 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here’s why I used these parameters (.github/workflows/links-check.yml):
--accept 200,403
We accept 403 because sites like Medium, npmjs, and Twitter/X block bots/scrapers and commonly return a 403 even when the link is valid. Since these cases are rare in .md files, accepting 403 avoids false positives without affecting the usefulness of the check.
--max-concurrency 5
Limiting concurrency is necessary to avoid services like GitHub returning HTTP 429 (Too Many Requests) for pages that are otherwise accessible. Using 5 threads is enough, it prevents hitting rate limits while still keeping the link check reasonably fast.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct