-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Haxe logo #4826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
piratabrasileiro1
wants to merge
11
commits into
github:main
Choose a base branch
from
piratabrasileiro1:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Haxe logo #4826
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Lima Lopes <[email protected]>
what i do wrong? |
jmeridth
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Confirmed the logo matches what is at https://github.com/HaxeFoundation
Looks like you have some linting to possibly fix. I'll look at this in a minute. |
The test failure is because the filename needs to be |
Signed-off-by: Gabriel Lima Lopes <[email protected]>
quakec added Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png
, square, dimensions 288x288, size <= 75 kB)index.md
)Curating a new topic or collection
https://github.com/topics/[NAME]
orhttps://github.com/collections/[NAME]
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
HAXE logo image
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.