-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Haxe logo #4826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Haxe logo #4826
Conversation
Signed-off-by: Gabriel Lima Lopes <[email protected]>
what i do wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Confirmed the logo matches what is at https://github.com/HaxeFoundation
Looks like you have some linting to possibly fix. I'll look at this in a minute. |
The test failure is because the filename needs to be |
Signed-off-by: Gabriel Lima Lopes <[email protected]>
quakec added Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
Signed-off-by: Gabriel Lima Lopes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are a couple of extra files in this PR that don't match the required formats. Can this be cleaned up?
wait i will delete the wrong commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the help
yes, they are simple mistake |
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png
, square, dimensions 288x288, size <= 75 kB)index.md
)Curating a new topic or collection
https://github.com/topics/[NAME]
orhttps://github.com/collections/[NAME]
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
HAXE logo image
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.