-
-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Capitalize PRINT_VERBOSE
macro to match other macros
#100224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Capitalize PRINT_VERBOSE
macro to match other macros
#100224
Conversation
4b2ca26
to
c4b5b91
Compare
c4b5b91
to
3c31863
Compare
3c31863
to
8f62399
Compare
The name conflict part of the issue has been solved by #102062. Now, there's still merit in discussing whether we want to make the macro I'm personally more for the latter, but I wouldn't strongly oppose the former if there's consensus that it's the way to go. |
It fixes it on the Godot side. We still kind of have it on the godot-cpp side, although, we're working around it by making it a function, and maybe have a couple other options to work around it if we want
There are semantic differences between functions and macros, so I'd personally be for |
aa29d8c
to
1183f70
Compare
fd356d5
to
33341d2
Compare
2bce9c6
to
d4087f4
Compare
118a968
to
0985dea
Compare
53111e1
to
f4de73e
Compare
PRINT_VERBOSE
macro to avoid a conflict with UtilityFunctionsPRINT_VERBOSE
macro to match other macros
f4de73e
to
cd0fb47
Compare
cd0fb47
to
a1ba06f
Compare
a1ba06f
to
8552ea9
Compare
8552ea9
to
1500ff5
Compare
This PR changes the
print_verbose
macro toPRINT_VERBOSE
, for 3 reasons:UtilityFunctions
: Fixprint_verbose()
macro conflicting withUtilityFunctions::print_verbose()
godot-cpp#1668VariantUtilityFunctions
, avoiding this awkwardness:This PR may minorly affect compatibility with third-party modules, but does not change the exposed scripting API. However, it is trivial for third-party modules to either update their code or add
print_verbose
as an alias.