-
-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Add option to change virtual keyboard type
for all text input nodes
#104171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add option to change virtual keyboard type
for all text input nodes
#104171
Conversation
4d6fdcb
to
30d2b3f
Compare
virtual keyboard type
for all text input nodes
virtual keyboard type
for all text input nodesvirtual keyboard type
for all text input nodes
726ac83
to
ebf4454
Compare
Just to make it clear, this PR is ready for review. |
Test project: test_input_virtual.zip The tests on 2 devices were ok. (Google Pixel smartphone and Samsung tablet) Can Details%SpinBox.get_line_edit().virtual_keyboard_enabled
%SpinBox.get_line_edit().virtual_keyboard_type Maybe like (a clean solution would probably be inheritance, C++ allows multiple inheritance, but only one class can be passed to class SpinBox : public Range {
GDCLASS(SpinBox, Range);
LineEdit *line_edit = nullptr;
---------
void SpinBox::set_editable(bool p_enabled) {
line_edit->set_editable(p_enabled);
queue_redraw();
}
|
We can do something like |
ebf4454
to
0d629f8
Compare
0d629f8
to
a23acbb
Compare
I encountered an issue where, the keyboard type for |
Closes godotengine/godot-proposals#11996 and closes godotengine/godot-proposals#7449
virtual keyboard type
in TextEdit and CodeEdit.virtual keyboard type
default to KEYBOARD_TYPE_NUMBER_DECIMAL for SpinBox.