Add layout and focus behavior unit test for Control #107037
Open
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwertychomp
suggested changes
Jul 24, 2025
Comment on lines
+31
to
+34
| #include "scene/gui/control.h" | ||
| #include "scene/main/window.h" | ||
| #include "scene/main/scene_tree.h" | ||
| #include "tests/test_macros.h" |
There was a problem hiding this comment.
Suggested change
| #include "scene/gui/control.h" | |
| #include "scene/main/window.h" | |
| #include "scene/main/scene_tree.h" | |
| #include "tests/test_macros.h" | |
| #include "scene/gui/control.h" | |
| #include "scene/main/scene_tree.h" | |
| #include "scene/main/window.h" | |
| #include "tests/test_macros.h" |
Comment on lines
+60
to
+65
| CHECK_MESSAGE( | ||
| child->get_position().is_equal_approx(Vector2(100, 100)), | ||
| "Child should be positioned at 25% of parent size."); | ||
| CHECK_MESSAGE( | ||
| child->get_size().is_equal_approx(Vector2(200, 200)), | ||
| "Child should be sized to 50% of parent width and height."); |
There was a problem hiding this comment.
Suggested change
| CHECK_MESSAGE( | |
| child->get_position().is_equal_approx(Vector2(100, 100)), | |
| "Child should be positioned at 25% of parent size."); | |
| CHECK_MESSAGE( | |
| child->get_size().is_equal_approx(Vector2(200, 200)), | |
| "Child should be sized to 50% of parent width and height."); | |
| CHECK_MESSAGE( | |
| child->get_position().is_equal_approx(Vector2(100, 100)), | |
| "Child should be positioned at 25% of parent size."); | |
| CHECK_MESSAGE( | |
| child->get_size().is_equal_approx(Vector2(200, 200)), | |
| "Child should be sized to 50% of parent width and height."); |
Comment on lines
+72
to
+77
| CHECK_MESSAGE( | ||
| child->get_focus_neighbour(SIDE_LEFT) == NodePath("LeftControl"), | ||
| "Left focus neighbor should be correctly set."); | ||
| CHECK_MESSAGE( | ||
| child->get_focus_neighbour(SIDE_RIGHT) == NodePath("RightControl"), | ||
| "Right focus neighbor should be correctly set."); |
There was a problem hiding this comment.
Suggested change
| CHECK_MESSAGE( | |
| child->get_focus_neighbour(SIDE_LEFT) == NodePath("LeftControl"), | |
| "Left focus neighbor should be correctly set."); | |
| CHECK_MESSAGE( | |
| child->get_focus_neighbour(SIDE_RIGHT) == NodePath("RightControl"), | |
| "Right focus neighbor should be correctly set."); | |
| CHECK_MESSAGE( | |
| child->get_focus_neighbour(SIDE_LEFT) == NodePath("LeftControl"), | |
| "Left focus neighbor should be correctly set."); | |
| CHECK_MESSAGE( | |
| child->get_focus_neighbour(SIDE_RIGHT) == NodePath("RightControl"), | |
| "Right focus neighbor should be correctly set."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contributes to issue #43440.
I have added unit tests to check anchor margins to position a child Control within a parent. Verifies that position and size are calculated correctly after the scene is processed. Also checks focus neighbor: the test sets left and right focus neighbors using set_focus_neighbour() and checks that get_focus_neighbour() returns the expected NodePath.