-
-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Remove the need to have a display name for built-in action overrides #107487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e8f9975
to
7e1346b
Compare
7e1346b
to
619c8de
Compare
The code looks good, but where are these names displayed? 🤔 |
The new strings added in this PR are not referenced anywhere, directly. I tried justifying their addition but I can't really find a reason as to why they're here. It's seemingly arbitrary. |
They are referenced in the code like any other built-in with an existing description. Take for example
What I did is making sure we have a description for all builtin actions. The goal was consistency rather than an arbitrary change.
That's a good question, and after checking I didn't find any usage in the editor. If the description is not used then maybe we should get rid of it all together. But then it seems we are still maintaining that list #107471 #87883 #76829 |
Some action names are displayed in context menus in LineEdit/TextEdit. |
Yeah these 2 changes are fine. |
619c8de
to
a1395f1
Compare
This PR
Adds missing built-in action display names"ui_swap_input_direction "