Create an undo/redo action when pinning a SoftBody3D point in the editor #108291
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you get around to rebasing this, please trim the commit message to just the title. In particular: we don't want any commits mentioning issues/PR by ID, as that would cause unwanted notifications |
Previously if you pinned a point by clicking on one of the soft body vertex handles the scene was not marked as modified, and the action could not be undone by hitting Ctrl-Z.
simpkins
force-pushed
the
soft_body_pin_gizmo
branch
from
77a6da9 to
8b6cc6a
Compare
Calinou
reviewed
Jul 28, 2025
| const bool is_pinned = soft_body->is_point_pinned(p_id); | ||
|
|
||
| EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton(); | ||
| undo_redo->create_action(vformat(TTR("%s SoftBody3D pinned point %d."), is_pinned ? "Remove" : "Add", p_id)); |
There was a problem hiding this comment.
Most undo/redo action names don't end with a period currently, so we should adjust this for consistency:
Suggested change
| undo_redo->create_action(vformat(TTR("%s SoftBody3D pinned point %d."), is_pinned ? "Remove" : "Add", p_id)); | |
| undo_redo->create_action(vformat(TTR("%s SoftBody3D pinned point %d"), is_pinned ? "Remove" : "Add", p_id)); |
Calinou
reviewed
Jul 28, 2025
There was a problem hiding this comment.
Tested locally, I noticed some issues:
- Undo/redo works, but it doesn't update the gizmos you see in the 3D editor until you hover any of them with the mouse.
- If I change the subdivision count in the PlaneMesh and edit points without reloading the scene, I'll get error messages about the vertex count being too low for the pinned point index I'm trying to set, but it's still working. (This issue may be present before this PR already, but I thought I'd report it nonetheless.)
Both of these issues can be seen in this video:
soft_body_undo_redo.mp4
Testing project: test_pr_108291.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you pinned a point by clicking on one of the soft body vertex handles the scene was not marked as modified, and the action could not be undone by hitting Ctrl-Z.
I ran into this in my own development, but I suspect that the scene not getting marked as modified is probably the root cause of issue #106325, so I suspect this change fixes that issue.
bugsquad edit: fixes #106325