Make rotation gizmo white outline a 4th handle that rotates around the camera's view-axis #108608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryevdokimov
force-pushed
the
camera-view-axis-rotation
branch
from
d76bc2e to
2bf683f
Compare
ryevdokimov
force-pushed
the
camera-view-axis-rotation
branch
2 times, most recently
from
db6f08a to
9e6438c
Compare
ryevdokimov
force-pushed
the
camera-view-axis-rotation
branch
from
9e6438c to
c6bae67
Compare
Calinou
approved these changes
Jul 24, 2025
| surftool->commit(axis_gizmo[i]); | ||
| // Lines to visualize transforms locked to an axis/plane | ||
| { | ||
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); |
There was a problem hiding this comment.
Suggested change
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); | |
| Ref<SurfaceTool> surftool; | |
| surftool.instantiate(); |
Preferred syntax
| surftool->add_vertex(points[2]); | ||
| surftool->add_vertex(points[3]); | ||
|
|
||
| Ref<StandardMaterial3D> plane_mat = memnew(StandardMaterial3D); |
There was a problem hiding this comment.
Suggested change
| Ref<StandardMaterial3D> plane_mat = memnew(StandardMaterial3D); | |
| Ref<StandardMaterial3D> plane_mat; | |
| plane_mat.instantiate(); |
| vec[i] = 1; | ||
| // Plane Scale | ||
| { | ||
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); |
There was a problem hiding this comment.
Suggested change
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); | |
| Ref<SurfaceTool> surftool; | |
| surftool.instantiate(); |
| if (i < 3) { | ||
| // Scale | ||
| { | ||
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); |
There was a problem hiding this comment.
Suggested change
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); | |
| Ref<SurfaceTool> surftool; | |
| surftool.instantiate(); |
| { | ||
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); | ||
| surftool->begin(Mesh::PRIMITIVE_TRIANGLES); | ||
| Ref<ShaderMaterial> rotate_mat = memnew(ShaderMaterial); |
There was a problem hiding this comment.
Suggested change
| Ref<ShaderMaterial> rotate_mat = memnew(ShaderMaterial); | |
| Ref<ShaderMaterial> rotate_mat; | |
| rotate_mat.instantiate(); |
| surftool->add_vertex(points[2]); | ||
| surftool->add_vertex(points[3]); | ||
|
|
||
| Ref<StandardMaterial3D> plane_mat = memnew(StandardMaterial3D); |
There was a problem hiding this comment.
Suggested change
| Ref<StandardMaterial3D> plane_mat = memnew(StandardMaterial3D); | |
| Ref<StandardMaterial3D> plane_mat; | |
| plane_mat.instantiate(); |
| surftool->commit(move_gizmo[i]); | ||
| // Plane Translation | ||
| { | ||
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); |
There was a problem hiding this comment.
Suggested change
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); | |
| Ref<SurfaceTool> surftool; | |
| surftool.instantiate(); |
| if (i < 3) { | ||
| //translate | ||
| { | ||
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); |
There was a problem hiding this comment.
Suggested change
| Ref<SurfaceTool> surftool = memnew(SurfaceTool); | |
| Ref<SurfaceTool> surftool; | |
| surftool.instantiate(); |
|
|
||
| if (i < 3) { | ||
| // Only create standard materials for X, Y, Z axes (move/scale gizmos) | ||
| mat = memnew(StandardMaterial3D); |
There was a problem hiding this comment.
Suggested change
| mat = memnew(StandardMaterial3D); | |
| mat.instantiate(); |
…e camera's view-axis
ryevdokimov
force-pushed
the
camera-view-axis-rotation
branch
from
c6bae67 to
cc1389a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires and includes: #108576
Common functionality in other 3D software that increases the usability of the rotation gizmo.
Made the white outline slightly larger so it's more distinct and easier to select.
Everything else should work as expected or at least how #108576 works.
2025-07-15.15-36-41.mp4