Skip to content

Fix shader editor menu switch on hover for file button #108877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Jul 22, 2025

Fixes: #108876

Screencast_20250722_223753.webm

Switch on hover is turned off for File button in the visual shader editor. It felt a bit strange to have file and mange varyings switch on hover when they are so far away from each other.

Screenshot_20250722_223841

@Giganzo Giganzo requested review from a team as code owners July 22, 2025 20:44
@bruvzg bruvzg added this to the 4.5 milestone Jul 23, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

Note that the original issue doesn't apply to 4.4.1, so this can't be cherry-picked.

@Repiteo Repiteo merged commit 5c1db32 into godotengine:master Jul 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File button in the Shader editor menu bar is not switching on hover like the other buttons
4 participants