Skip to content

chore: remove obsolete region tags #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meredithslota merged 8 commits into from
Nov 8, 2022
Merged

chore: remove obsolete region tags #1122

meredithslota merged 8 commits into from
Nov 8, 2022

Conversation

@meredithslota
Copy link
Contributor

@meredithslota meredithslota commented Nov 8, 2022

Supercedes #652 ☕️

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Nov 8, 2022
@meredithslota meredithslota added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2022
@meredithslota
Copy link
Contributor Author

meredithslota commented Nov 8, 2022

Context: go/firestore-region-tags-normalization-2020q4

@meredithslota
Copy link
Contributor Author

meredithslota commented Nov 8, 2022

Adding the do not merge label until I can make sure SnippetBot is happy and all references are removed from docs (replaced with correct region tags).

@meredithslota meredithslota marked this pull request as ready for review November 8, 2022 20:02
@snippet-bot
Copy link

snippet-bot bot commented Nov 8, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 69 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@meredithslota meredithslota removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2022
@meredithslota meredithslota requested a review from kolea2 November 8, 2022 20:20
@meredithslota meredithslota merged commit 801a7ec into main Nov 8, 2022
@meredithslota meredithslota deleted the normalize-region-tags branch November 8, 2022 21:39
@meredithslota meredithslota mentioned this pull request Nov 9, 2022
Closed
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@meredithslota @cherylEnkidu
chore: remove obsolete region tags (#1122)
ff36ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/java-firestore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meredithslota @kolea2