Skip to content

docs: remove dual-homed region tags#652

Closed
Strykrol wants to merge 5 commits intogoogleapis:mainfrom
Strykrol:firestore
Closed

docs: remove dual-homed region tags#652
Strykrol wants to merge 5 commits intogoogleapis:mainfrom
Strykrol:firestore

Conversation

@Strykrol
Copy link

Removes unnecessary region tags now that new ones have proliferated in docs. Added wrapped region tags to align with other same-language Firestore samples.

@Strykrol Strykrol requested a review from a team May 26, 2021 22:25
@snippet-bot
Copy link

snippet-bot bot commented May 26, 2021

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 58 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label May 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2021
@Strykrol
Copy link
Author

Region tag violations are resolved in (submitted) cl/376017137, which hasn't quite percolated apparently.

@Strykrol
Copy link
Author

Strykrol commented Jun 3, 2021

Could I please get someone to refresh the snippet bot? I am expecting these violations to resolve.

@dandhlee dandhlee added the snippet-bot:force-run Force snippet-bot runs its logic label Jun 10, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jun 10, 2021
@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 10, 2021

@Strykrol Thanks for respecting snippet-bot!

In order to refresh snippet-bot comment, you can do eithrer 1) add snippet-bot:force-run label 2) check the checkbox in the snippet-bot comment 3) close and reopen the PR.

Also, snippet-bot already thinks there's no violations, but somehow it failed to update the check status. I'll figure out why it's happening, but for now, you can ignore the snippet-bot check.

However unfortunately ci/units (8) is failing, so you need to fix it before merging because it's a mandatory check.

@Strykrol
Copy link
Author

Not sure why the units would have failed, but I need the updated status reports so I can see what to fix (if problems are still present).

@Strykrol
Copy link
Author

Strykrol commented Jul 9, 2021

Could someone please rerun or otherwise expedite the tests?

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2021
@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 9, 2021

@Strykrol I added kokoro:force-run and pushed the approve button for Github workflow.

@Strykrol
Copy link
Author

Two things:

  • I cannot merge this myself, someone else will need to please :)
  • I'm wrapping up my contract @ Google, but can continue updating this PR if needed

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2021
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2021
suztomo
suztomo previously approved these changes Feb 15, 2022
@suztomo suztomo dismissed their stale review February 15, 2022 18:21

mistake

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 27, 2022
@meredithslota
Copy link
Contributor

Closing in favor of #1122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants