feat: secrets management admin UI #105953

w1kman · 2025-05-23T12:23:23Z

What is this feature?

UI for secrets management (see PR#97837)

Note: Client-side validation of form values (based on SecureValue spec)

Why do we need this feature?

For users to be able to create, read, update, and delete secrets.

Who is this feature for?

Currently, admin users only

Special notes for your reviewer:

To test, you can make run on this branch, with custom.ini settings:

app_mode = development 

[feature_toggles]
grafanaAPIServerWithExperimentalAPIs = true
grafanaAPIServerEnsureKubectlAccess = true
secretsManagementAppPlatform = true

Considerations for further development:

Make use of createdBy/modifiedBy (user id) (e.g. hardlink to users/edit/<uid>
Consider splitting up RegExp validation to be able to be more specific with error messages
Polling interval for pending secrets should probably have an incremental delay (currently 500ms, which is fine as long as we are on a happy path).
Investigate pagination of list API

Please check that:

It works as expected from a user's perspective.
If this is a pre-GA feature, it is behind a feature toggle.
The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Simple implementation (WIP) of UI with in-memory stubs.

…gement-admin-ui # Conflicts: # public/app/core/reducers/root.ts

API currently doesn't report back with a pending/progress state while a secret is being provisioned.

…gement-admin-ui # Conflicts: # public/app/core/reducers/root.ts

…gement-admin-ui

`audiences` => `decrypters`

…gement-admin-ui

- Also removed the possibility to enter custom values.

…gement-admin-ui

…eper)

…ui' into w1kman/secrets-management-admin-ui # Conflicts: # public/app/features/secrets-management/components/SecretForm.tsx # public/app/features/secrets-management/constants.ts

- invalid import (`@grafana/ui/`) - "missing" `Prop` export from `@grafana/ui/Input`

- update `fill` for delete button in `SecretItem` - turn off autocomplete for secret value

…gement-admin-ui

- add /admin/secrets to `api.go` - add/update translations - replace secret value input with textarea

…05747)

- `SecretValueInput.tsx` - `SecretsSearchEmptyState.tsx` - `SecretList.tsx` - `SecretsEmptyState.tsx` - `SecretItem.tsx`

w1kman · 2025-06-11T09:34:23Z

I'd missed the betterer step - converting to draft while fixing.

w1kman

self-review attempt no.2 ✅

danielkenlee · 2025-06-18T12:25:23Z

Hi @w1kman - I checked out the branch w1kman/secrets-management-admin-ui and created a couple of secrets. I noticed it changed the name after clicking create. Have you encountered this before?

w1kman · 2025-06-18T15:26:22Z

the name after clicking create. Have you encountered this before?

Yeah, if the name is empty, the backend will assign a random name. I will take a look.

…gement-admin-ui # Conflicts: # public/app/core/reducers/root.ts # public/app/store/configureStore.ts

…al).

w1kman · 2025-06-18T16:09:52Z

I noticed it changed the name after clicking create. Have you encountered this before?

I've pushed a fix for the random name, as well as an update on handling secret updates and translation dependencies.

danielkenlee · 2025-06-20T11:49:43Z

Hi Thomas, I've completed testing on all the functionality of the page. This has been documented here: Grafana Secrets management UI - PR review

Almost everything is working as expected! :) I have a couple of follow up items here:

Investigate search input problem. The search bar doesn’t accept “-” character to be included in the search term.
The secure value input seems to accept a LOT of text. Check if we have size limits on the input on the frontend.

…gement-admin-ui

- Delete secret modal: copy updated (see Miro). - Improve search filter interactions and capabilities - Improve name validation regexp (check last char to be alphanumeric) - Improve label.(name|value) validation regexp (check last char to be alphanumeric) - Add secure value limit (24kb)

w1kman · 2025-06-24T08:41:38Z

@danielkenlee

Investigate search input problem. The search bar doesn’t accept “-” character to be included in the search term.

The FilterInput had a prop called escapeRegex which was set to true by default. I've turned off that feature, as well as added the same type of transformation to the filter value before the list of secrets is filtered (e.g. "My cool filter" -> "my-cool-filter")

The secure value input seems to accept a LOT of text. Check if we have size limits on the input on the frontend.

I've talked to @macabu about this. 24kb seems to be the lowest limit (Azure) we need to support. I've updated the client validation for the value to have a max length of 24576 chars

…nto w1kman/secrets-management-admin-ui

github-actions · 2025-07-26T02:16:12Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

macabu · 2025-07-28T08:04:47Z

Closing as stale! This moved!

w1kman and others added 30 commits February 11, 2025 21:02

feat: secret management draft ui

0c00291

Simple implementation (WIP) of UI with in-memory stubs.

feat: secret management draft ui

e6f9897

Simple implementation (WIP) of UI with in-memory stubs.

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

ace8519

…gement-admin-ui # Conflicts: # public/app/core/reducers/root.ts

fix: optimistic update of local store

fc79679

API currently doesn't report back with a pending/progress state while a secret is being provisioned.

fix: optimistic update of local store

a040d19

API currently doesn't report back with a pending/progress state while a secret is being provisioned.

fix: copy button paddings and margins

956df8a

fix: copy button paddings and margins

aa3b2ff

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

ac58054

…gement-admin-ui # Conflicts: # public/app/core/reducers/root.ts

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

330935c

…gement-admin-ui

fix: update external resource spec

6f3ba7f

`audiences` => `decrypters`

fix: update external resource spec

c35c300

`audiences` => `decrypters`

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

fc5ef77

…gement-admin-ui

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

3d288b6

…gement-admin-ui

add allowed list of descrypters

1540179

- Also removed the possibility to enter custom values.

add allowed list of descrypters

aaaf860

- Also removed the possibility to enter custom values.

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

b665671

…gement-admin-ui

SecretsManagement: update allowed decrypters constant (and default ke…

15c8e7a

…eper)

Merge remote-tracking branch 'origin/w1kman/secrets-management-admin-…

d89a140

…ui' into w1kman/secrets-management-admin-ui # Conflicts: # public/app/features/secrets-management/components/SecretForm.tsx # public/app/features/secrets-management/constants.ts

fix: build issues

8936f50

- invalid import (`@grafana/ui/`) - "missing" `Prop` export from `@grafana/ui/Input`

update ui to handle label/value for decrypters

7f11f26

- update `fill` for delete button in `SecretItem` - turn off autocomplete for secret value

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

a49523e

…gement-admin-ui

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

e3b2c27

…gement-admin-ui

migrate to RTK query (wip)

095b7b7

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

aa424ba

…gement-admin-ui

refactor/update secrets management

ab77457

- add /admin/secrets to `api.go` - add/update translations - replace secret value input with textarea

add labels to secret form

d7d985c

add util function for invalid field detection

8907ad3

update breakpoint for wrap detection

2e4c03e

SecureValues: Update decrypter format to get rid of actor_ prefix (#1…

8420d6d

…05747)

update translation for secrets and add tests

5c03e13

- `SecretValueInput.tsx` - `SecretsSearchEmptyState.tsx` - `SecretList.tsx` - `SecretsEmptyState.tsx` - `SecretItem.tsx`

w1kman requested review from a team and grafanabot as code owners June 9, 2025 14:17

w1kman requested review from aocenas and Clarity-89 and removed request for a team June 9, 2025 14:17

w1kman marked this pull request as draft June 11, 2025 09:33

fix betterer issues and style guide issues

9980a20

w1kman commented Jun 11, 2025

View reviewed changes

w1kman marked this pull request as ready for review June 11, 2025 11:00

fix prettier issue

01a4140

fix name issue when creating and updating.

f3cbc89

w1kman requested a review from a team as a code owner June 18, 2025 15:56

w1kman added 3 commits June 18, 2025 17:57

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

819af68

…gement-admin-ui # Conflicts: # public/app/core/reducers/root.ts # public/app/store/configureStore.ts

fix updated translation usage.

f526244

fix updated translation usage (remove dependency @grafana/i18n/intern…

068ca60

…al).

w1kman added 2 commits June 24, 2025 08:31

Merge branch 'secret-service/feature-branch' into w1kman/secrets-mana…

9f93dbd

…gement-admin-ui

dana-axinte added 2 commits June 25, 2025 10:35

Merge remote-tracking branch 'origin/secret-service/feature-branch' i…

ee13e25

…nto w1kman/secrets-management-admin-ui

Merge remote-tracking branch 'origin/secret-service/feature-branch' i…

c7458c7

…nto w1kman/secrets-management-admin-ui

github-actions bot added the stale Issue with no recent activity label Jul 26, 2025

macabu closed this Jul 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: secrets management admin UI #105953

feat: secrets management admin UI #105953

w1kman commented May 23, 2025 •

edited

Loading

Uh oh!

w1kman commented Jun 11, 2025

Uh oh!

w1kman left a comment

Uh oh!

danielkenlee commented Jun 18, 2025 •

edited

Loading

Uh oh!

w1kman commented Jun 18, 2025

Uh oh!

w1kman commented Jun 18, 2025

Uh oh!

danielkenlee commented Jun 20, 2025

Uh oh!

w1kman commented Jun 24, 2025

Uh oh!

github-actions bot commented Jul 26, 2025

Uh oh!

macabu commented Jul 28, 2025

Uh oh!

Uh oh!

feat: secrets management admin UI #105953

feat: secrets management admin UI #105953

Conversation

w1kman commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w1kman commented Jun 11, 2025

Uh oh!

w1kman left a comment

Choose a reason for hiding this comment

Uh oh!

danielkenlee commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w1kman commented Jun 18, 2025

Uh oh!

w1kman commented Jun 18, 2025

Uh oh!

danielkenlee commented Jun 20, 2025

Uh oh!

w1kman commented Jun 24, 2025

Uh oh!

github-actions bot commented Jul 26, 2025

Uh oh!

macabu commented Jul 28, 2025

Uh oh!

Uh oh!

w1kman commented May 23, 2025 •

edited

Loading

danielkenlee commented Jun 18, 2025 •

edited

Loading