add allowed list of descrypters

- Also removed the possibility to enter custom values.
grafana · w1kman · Feb 11, 2025 · Feb 11, 2025 · Feb 12, 2025 · Feb 19, 2025
commit 1540179a1b4221bfd644f07d9e7b016bd80e46bc
diff --git a/public/app/features/secrets-management/components/SecretForm.tsx b/public/app/features/secrets-management/components/SecretForm.tsx
@@ -2,7 +2,7 @@ import { Controller, useForm } from 'react-hook-form';
 
 import { Button, Field, Input, MultiSelect, RadioButtonGroup, Stack } from '@grafana/ui';
 
-import { MOCKED_SECRET_AUDIENCES } from '../constants';
+import { ALLOWED_SECRET_DECRYPTERS } from '../constants';
 
 import { SecretInput } from './SecretInput';
 
@@ -32,7 +32,7 @@ export function SecretForm({
   disableNameField = false,
 }: BaseSecretFormProps) {
   const audiences = [
-    ...MOCKED_SECRET_AUDIENCES.map((audience) => ({ label: audience, value: audience })),
+    ...ALLOWED_SECRET_DECRYPTERS.map((audience) => ({ label: audience, value: audience })),
     ...(initialValues?.audiences ?? []),
   ];
 
@@ -102,7 +102,9 @@ export function SecretForm({
         <Controller
           control={control}
           name="audiences"
-          render={({ field: { ref, ...field } }) => <MultiSelect allowCustomValue options={audiences} {...field} />}
+          render={({ field: { ref, ...field } }) => (
+            <MultiSelect placeholder="Choose decrypter(s)" options={audiences} {...field} />
+          )}
         />
       </Field>
       <Stack gap={1} justifyContent="flex-end">

diff --git a/public/app/features/secrets-management/constants.ts b/public/app/features/secrets-management/constants.ts
@@ -1,9 +1,9 @@
-// As per pkg/tests/secret/testdata/secure-value-xyz.yaml
-export const MOCKED_SECRET_AUDIENCES = [
-  'k6.grafana.app/app-name-1',
-  'k6.grafana.app/app-name-2',
-  'entity.grafana.app/*',
+// @see https://github.com/grafana/grafana-enterprise/blob/secret-service/feature-branch/src/pkg/extensions/secret/decrypt/allow_list.go
+export const ALLOWED_SECRET_DECRYPTERS = [
+  'k6.grafana.app/secret-decrypter-thing',
+  'synthetic-monitoring.grafana.app/secret-decrypter-thing',
 ];
+
 export const MOCKED_SECRET_KEEPER = 'my-keeper-1';
 
 export const MOCKED_FILTER_OPTIONS = [