New Log Details: Support multiple log details displayed #108327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
added
no-backport
L2D2Grafana
approved these changes
Jul 18, 2025
Oh, good find! That can definitely be improved.
Yeah, search is ok. The highlight to disable are line filters. To test, use a line filter and see the differences with and without highlighting. |
matyax
force-pushed
the
matyax/logs-panel-v2-new-viz-multi-details
branch
from
205c3bd to
8b5efa0
Compare
|
Unfortunately, the tab flickering comes from the tabs component with suffix. Flickering.mov |
macabu
pushed a commit
that referenced
this pull request
Jul 22, 2025
* LogLine: optionally highlight search based on syntax highlighting state * Log Details: support multiple details open * Translations * Add test * LogLine: allow to highlight frontend searches * LogLine: improve hover vs details displayed colors * LogLineDetails: add scroll to log line option and improve toggling behavior * Translations * LogLineDetails: prevent sidebar re-rendering * LogLineDetails: more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #99075, this PR adds support for multiple displayed fields. For the Sidebar, it displays them as tabs. For inline, they are individually toggled.
Additional change: the
syntax highlightingoption controls the highlight of search words when string filters are used. Closes #68572Demo:
Demo.mov