Skip to content

New Log Details: Support multiple log details displayed #108327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 21, 2025
Merged

New Log Details: Support multiple log details displayed #108327

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3209227
LogLine: optionally highlight search based on syntax highlighting state
matyax Jul 18, 2025
46bc50d
Log Details: support multiple details open
matyax Jul 18, 2025
7404544
Translations
matyax Jul 18, 2025
b17b81e
Add test
matyax Jul 18, 2025
d99dd85
LogLine: allow to highlight frontend searches
matyax Jul 18, 2025
bbee9ac
LogLine: improve hover vs details displayed colors
matyax Jul 19, 2025
8b5efa0
LogLineDetails: add scroll to log line option and improve toggling be…
matyax Jul 19, 2025
4743098
Translations
matyax Jul 21, 2025
807c6c7
LogLineDetails: prevent sidebar re-rendering
matyax Jul 21, 2025
330acc4
LogLineDetails: more tests
matyax Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
LogLine: optionally highlight search based on syntax highlighting state
  • Loading branch information
@matyax
matyax committed Jul 21, 2025
commit 32092273ecbaa9393323c73d3f9223862cfd2290
5 changes: 4 additions & 1 deletion public/app/features/logs/components/panel/LogLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ const LogLineBody = ({ log, styles }: { log: LogListModel; styles: LogLineStyles
const { matchingUids, search } = useLogListSearchContext();

const highlight = useMemo(() => {
if (!syntaxHighlighting) {
return undefined;
}
const searchWords = log.searchWords && log.searchWords[0] ? log.searchWords.slice() : [];
if (search && matchingUids?.includes(log.uid)) {
searchWords.push(search);
Expand All @@ -331,7 +334,7 @@ const LogLineBody = ({ log, styles }: { log: LogListModel; styles: LogLineStyles
return undefined;
}
return { searchWords, highlightClassName: styles.matchHighLight };
}, [log.searchWords, log.uid, matchingUids, search, styles.matchHighLight]);
}, [log.searchWords, log.uid, matchingUids, search, styles.matchHighLight, syntaxHighlighting]);

if (log.hasAnsi) {
return (
Expand Down