-
Notifications
You must be signed in to change notification settings - Fork 12.8k
TableNG: Integrate hover and selection, DataLinkCell cleanup #108353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fastfrwrd
merged 24 commits into
main
from
fastfrwrd/tableng-style-tweaks-minus-row-height
Jul 23, 2025
Merged
TableNG: Integrate hover and selection, DataLinkCell cleanup #108353
fastfrwrd
merged 24 commits into
main
from
fastfrwrd/tableng-style-tweaks-minus-row-height
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
reviewed
Jul 19, 2025
leeoniya
reviewed
Jul 19, 2025
leeoniya
reviewed
Jul 19, 2025
leeoniya
reviewed
Jul 19, 2025
leeoniya
reviewed
Jul 19, 2025
leeoniya
reviewed
Jul 19, 2025
packages/grafana-ui/src/components/Table/TableNG/Cells/JSONCell.tsx
Outdated
Show resolved
Hide resolved
leeoniya
reviewed
Jul 19, 2025
…le-tweaks-minus-row-height
fastfrwrd
commented
Jul 23, 2025
@@ -44,10 +43,6 @@ const SPARKLINE_RENDERER: TableCellRenderer = (props) => ( | |||
/> | |||
); | |||
|
|||
const JSON_RENDERER: TableCellRenderer = (props) => ( | |||
<JSONCell justifyContent={props.justifyContent} value={props.value} field={props.field} rowIdx={props.rowIdx} /> | |||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSONCell is now an AutoCell with a custom display
method!
leeoniya
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
area/panel/table
no-changelog
Skip including change in changelog/release notes
type/chore
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This has moved over from #108074, but without the
wrapText
enablement for DataLinks, and thus without the changes necessary to row height stuff, freeing up the change to be less risky overall.A number of style cleanups for TableNG, primarily centering around text overflow and presentation of some text-driven cell types.
display: inline
, and updates the cell class to explicitly usetext-overflow: ellipsis
, to ensure that overflowing text from these cell types has ellipses.textWrap
option like other text-based cells, and the calculation for its contents correctly derives its height from the concatenated content of the datalinks titles.display: inline
now and using text-align is a more appropriate way to style that content.[data-selected=true]
, which is a data attribute managed by react-data-grid on keyboard navigation.Special notes for your reviewer:
Please check that: