Skip to content

TableNG: Integrate hover and selection, DataLinkCell cleanup #108353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 23, 2025
+384 −293
Merged

TableNG: Integrate hover and selection, DataLinkCell cleanup #108353

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5f41f89
Table: Style cleanups (minus DataLinkCell word wrap)
fastfrwrd Jul 18, 2025
7513faf
kill JSONCell in favor of a custom display method and style overrides…
fastfrwrd Jul 22, 2025
ac1f3cc
remove unused type for JSONCellProps
fastfrwrd Jul 22, 2025
82f3596
add increased specificity to CSS selector
fastfrwrd Jul 22, 2025
22ebbac
remove inherit and rely on undefined
fastfrwrd Jul 22, 2025
82c2a0e
Merge remote-tracking branch 'origin/main' into fastfrwrd/tableng-sty…
fastfrwrd Jul 22, 2025
d030e6f
fix tests
fastfrwrd Jul 22, 2025
c070d33
Merge remote-tracking branch 'origin/main' into fastfrwrd/tableng-sty…
fastfrwrd Jul 22, 2025
17b9161
Merge branch 'main' into fastfrwrd/tableng-style-tweaks-minus-row-height
leeoniya Jul 22, 2025
8a19e03
shrink and optimize DataLinkCell
leeoniya Jul 23, 2025
262b92b
maybe
leeoniya Jul 23, 2025
3d9b10d
format files
fastfrwrd Jul 23, 2025
416b9bc
better
leeoniya Jul 23, 2025
b104db5
classname
leeoniya Jul 23, 2025
0a89835
add Pills and DataLink cells to kitchen sink
fastfrwrd Jul 23, 2025
2426045
add comment about align + justify, simplify datalinks targeting
fastfrwrd Jul 23, 2025
1c8ba25
simplify?
leeoniya Jul 23, 2025
aacce86
poke
leeoniya Jul 23, 2025
15b8795
tweak
leeoniya Jul 23, 2025
e217abf
revert
leeoniya Jul 23, 2025
ca6dfdc
fix one more z-index conflict
fastfrwrd Jul 23, 2025
f300516
clean up alignment tests
fastfrwrd Jul 23, 2025
9ece009
a couple more tests
fastfrwrd Jul 23, 2025
83451ed
make TableNG e2e tests more resilient to changes to the gdev dashboard
fastfrwrd Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment about align + justify, simplify datalinks targeting
  • Loading branch information
@fastfrwrd
fastfrwrd committed Jul 23, 2025
commit 24260451269f757a51ee18846d5ada6941c9c236
7 changes: 5 additions & 2 deletions packages/grafana-ui/src/components/Table/TableNG/TableNG.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,9 @@ export function TableNG(props: TableNGProps) {
field.display = displayJsonValue;
}

// For some cells, "aligning" the cell will mean aligning the inline contents of the cell with
// the text-align css property, and for others, we'll use justify-content to align the cell
// contents with flexbox. We always just get both and provide both when styling the cell.
const textAlign = getTextAlign(field);
const justifyContent = getJustifyContent(field);
const footerStyles = getFooterStyles(justifyContent);
Expand Down Expand Up @@ -978,11 +981,11 @@ const getCellStyles = (
paddingInline: theme.spacing(1),
borderRight: `2px solid ${theme.colors.border.medium}`,

'&:first-child': {
'&:first-of-type': {
paddingInlineStart: 0,
},

'&:last-child': {
'&:last-of-type': {
borderRight: 'none',
paddingInlineEnd: 0,
},
Expand Down
Loading