Skip to content

Fix README examples on requiring specific modules #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2016
Merged

Fix README examples on requiring specific modules #110

merged 1 commit into from
Dec 1, 2016

Conversation

francocatena
Copy link
Contributor

Some of the paths for requiring specific modules on the README where wrong. Should "fix" #109 and #106.

Cheers.

@joliss joliss merged commit 19fb230 into jquery-ui-rails:master Dec 1, 2016
@joliss
Copy link
Member

joliss commented Dec 1, 2016

Thanks!

@dcsaszar
Copy link

https://github.com/jquery-ui-rails/jquery-ui-rails/pull/110/files#diff-04c6e90faac2675aa89e2176d2eec7d8L193

This change looks wrong to me.
The README explicitly states:

In your application.css, require the corresponding CSS module (notice no widgets/ subdirectory here)

@dependabot-preview dependabot-preview bot mentioned this pull request Mar 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francocatena @joliss @dcsaszar