Always set chilled strings as sharing bytelist #8882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chilled strings are constructed much like frozen strings, reusing the same bytelist for each new instance. But unlike frozen strings, chilled strings may still be mutated for now. We mark all such strings as having a shared ByteList to ensure that it is copied before making modifications. Fixes jruby#8861
headius
force-pushed
the
restore_string_modify
branch
from
e85b975 to
856e840
Compare
headius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chilled strings are constructed much like frozen strings, reusing the same bytelist for each new instance. But unlike frozen strings, chilled strings may still be mutated for now. We mark all such strings as having a shared ByteList to ensure that it is copied before making modifications.
Fixes #8861