Skip to content

Always set chilled strings as sharing bytelist #8882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

Always set chilled strings as sharing bytelist #8882

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856e840
Always set chilled strings as sharing bytelist
headius Jul 1, 2025
9ebc06d
Add spec for debug chilled string mutation
headius Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add spec for debug chilled string mutation 
See #8861
  • Loading branch information
@headius
headius committed Jul 1, 2025
commit 9ebc06d295e8968bcc4a20e5978fc979ad8df3da
11 changes: 11 additions & 0 deletions spec/compiler/general_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1566,5 +1566,16 @@ def z_super
BZSuper.new.z_super
SUPER
end

it "compiles debug chilled strings that can be modified without impacting other strings" do
JRuby.runtime.instance_config.debugging_frozen_string_literal = true
run(<<~CHILLED) {|val| expect(val).to eq("")}
str = ""
str << "hello"
""
CHILLED
ensure
JRuby.runtime.instance_config.debugging_frozen_string_literal = false
end
end
end