-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
avoid coverage reporting when only executing test subset #12924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the action confirms it! Thank you for the fix :)
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 31s ⏱️ Results for commit 813b8fe. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: ci
Running LocalStack in CI environments
review: merge when ready
Signals to the reviewer that a PR can be merged if accepted
semver: patch
Non-breaking changes which can be included in patch releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With #12923 we fixed the upload of our coverage data, which didn't work since we moved from CircleCI to GitHub actions (implemented with #12708).
Unfortunately, we now publish the coverage data also for runs where we only execute a small subset of our tests (i.e. only the acceptance tests).
This PR aims at fixing this issue.
Changes
onlyAcceptanceTests
andenableTestSelection
arefalse
, i.e. we also run our integration tests and do not select the tests to execute (but execute all of them).Testing