fix partial coverage reporting #12939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alexrashed merged 5 commits into main from fix-coveralls-report-on-partial-2

Jul 31, 2025

Member

alexrashed commented Jul 31, 2025 •

edited

Loading

Motivation

With #12923 we fixed the coverage upload, and with #12924 we tried to fix the issue of reporting partial results.
Unfortunately, debugging job level conditionals in GitHub actions is notoriously hard / there isn't really a way to get proper debug information on how the conditions are evaluated.

Changes

Fixes the conditional for uploading the coverage report by switching to "not explicitly true" for the test selection and aceptancfe tests and considering the push event.
Fixes a conditional to forward the enableTestSelection correctly on the workflow call.

Testing


          fix conditional to avoid partial coverage upload

ab76b2c

alexrashed added this to the 4.8 milestone

alexrashed assigned k-a-il

alexrashed added the semver: patch label

github-actions bot commented Jul 31, 2025 •

edited

Loading

Test Results - Preflight, Unit

21 980 tests 20 246 ✅ 6m 16s ⏱️
1 suites 1 734 💤
1 files 0 ❌

Results for commit bcafcd6.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 31, 2025 •

edited

Loading

Test Results (amd64) - Acceptance

7 tests 5 ✅ 3m 21s ⏱️
1 suites 2 💤
1 files 0 ❌

Results for commit bcafcd6.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 31, 2025 •

edited

Loading

Test Results (arm64) - Acceptance

7 tests 5 ✅ 3m 16s ⏱️
1 suites 2 💤
1 files 0 ❌

Results for commit 6ddbdaa.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 31, 2025 •

edited

Loading

Test Results (amd64) - Integration, Bootstrap

5 files 5 suites 2h 19m 20s ⏱️
4 848 tests 4 367 ✅ 481 💤 0 ❌
4 854 runs 4 367 ✅ 487 💤 0 ❌

Results for commit 6ddbdaa.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 31, 2025 •

edited

Loading

Test Results (arm64) - Integration

4 files 4 suites 2h 21m 6s ⏱️
4 824 tests 4 342 ✅ 482 💤 0 ❌
4 830 runs 4 342 ✅ 488 💤 0 ❌

Results for commit 6ddbdaa.

♻️ This comment has been updated with latest results.

alexrashed force-pushed the fix-coveralls-report-on-partial-2 branch from 8cb76f9 to ba38569 Compare

July 31, 2025 10:47

alexrashed and others added 3 commits

July 31, 2025 13:36


          [revert-before-merge] remove push trigger for testing

c8fd3ab


          CI: update condition of report step for failed or canceleed wf


          fix test selection input evaluation

f5aac38

alexrashed force-pushed the fix-coveralls-report-on-partial-2 branch from ba38569 to f5aac38 Compare

July 31, 2025 11:36


          Revert "[revert-before-merge] remove push trigger for testing"

bcafcd6

This reverts commit c8fd3ab.

alexrashed marked this pull request as ready for review

July 31, 2025 11:59

alexrashed requested review from dfangl, dominikschubert, silv-io and k-a-il as code owners

July 31, 2025 11:59

k-a-il approved these changes

View reviewed changes

Contributor

k-a-il left a comment

LGTM 🚀

silv-io approved these changes

View reviewed changes

Member

silv-io left a comment

LGTM! Conditionals in GHA are indeed very painful

alexrashed merged commit f459293 into main

26 checks passed

alexrashed deleted the fix-coveralls-report-on-partial-2 branch

July 31, 2025 12:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels