Skip to content

DEPR: camelCase in offsets, get_offset #30340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 27, 2019
Merged

DEPR: camelCase in offsets, get_offset #30340

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
afe3050
DEPR: camelCase in offsets
jbrockmendel Dec 19, 2019
fcd58e9
GH ref
jbrockmendel Dec 19, 2019
20e60bb
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 19, 2019
a39d50e
troubleshoot ci
jbrockmendel Dec 19, 2019
e30d272
update usage
jbrockmendel Dec 19, 2019
ae19cf3
keeep trying
jbrockmendel Dec 20, 2019
df3ff50
throw everything at the wall
jbrockmendel Dec 21, 2019
4bfd4ef
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 21, 2019
eaf3b6d
just keep em both
jbrockmendel Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update usage
  • Loading branch information
@jbrockmendel
jbrockmendel committed Dec 19, 2019
commit e30d272d349b4e2e2549760f18847de3616c3b95
6 changes: 3 additions & 3 deletions pandas/tests/tseries/frequencies/test_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def test_series_datetime_index(freq):
@pytest.mark.parametrize(
"offset_func",
[
frequencies.get_offset,
frequencies._get_offset,
lambda freq: date_range("2011-01-01", periods=5, freq=freq),
],
)
Expand Down Expand Up @@ -528,8 +528,8 @@ def test_legacy_offset_warnings(offset_func, freq):


def test_ms_vs_capital_ms():
left = frequencies.get_offset("ms")
right = frequencies.get_offset("MS")
left = frequencies._get_offset("ms")
right = frequencies._get_offset("MS")

assert left == offsets.Milli()
assert right == offsets.MonthBegin()