Skip to content

DEPR: camelCase in offsets, get_offset #30340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 27, 2019
Merged

DEPR: camelCase in offsets, get_offset #30340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
afe3050
DEPR: camelCase in offsets
jbrockmendel Dec 19, 2019
fcd58e9
GH ref
jbrockmendel Dec 19, 2019
20e60bb
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 19, 2019
a39d50e
troubleshoot ci
jbrockmendel Dec 19, 2019
e30d272
update usage
jbrockmendel Dec 19, 2019
ae19cf3
keeep trying
jbrockmendel Dec 20, 2019
df3ff50
throw everything at the wall
jbrockmendel Dec 21, 2019
4bfd4ef
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Dec 21, 2019
eaf3b6d
just keep em both
jbrockmendel Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH ref
  • Loading branch information
@jbrockmendel
jbrockmendel committed Dec 19, 2019
commit fcd58e984e78f9ef84b9b6d57d97cb0583491ac4
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ Deprecations
is equivalent to ``arr[idx.get_loc(idx_val)] = val``, which should be used instead (:issue:`28621`).
- :func:`is_extension_type` is deprecated, :func:`is_extension_array_dtype` should be used instead (:issue:`29457`)
- :func:`eval` keyword argument "truediv" is deprecated and will be removed in a future version (:issue:`29812`)
- :meth:`DateOffset.isAnchored` and :meth:`DatetOffset.onOffset` are deprecated and will be removed in a future version, use :meth:`DateOffset.is_anchored` and :meth:`DateOffset.is_on_offset` instead (:issue:`?????`)
- :meth:`DateOffset.isAnchored` and :meth:`DatetOffset.onOffset` are deprecated and will be removed in a future version, use :meth:`DateOffset.is_anchored` and :meth:`DateOffset.is_on_offset` instead (:issue:`30340`)
- ``pandas.tseries.frequencies.get_offset`` is deprecated and will be removed in a future version, use ``pandas.tseries.frequencies.to_offset`` instead (:issue:`4205`)
- :meth:`Categorical.take_nd` is deprecated, use :meth:`Categorical.take` instead (:issue:`27745`)
- The parameter ``numeric_only`` of :meth:`Categorical.min` and :meth:`Categorical.max` is deprecated and replaced with ``skipna`` (:issue:`25303`)
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/tseries/offsets/test_offsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ def test_pickle_v0_15_2(self, datapath):
tm.assert_dict_equal(offsets, read_pickle(pickle_path))

def test_onOffset_deprecated(self, offset_types):
# use idiomatic naming
# GH#30340 use idiomatic naming
off = self._get_offset(offset_types)

ts = Timestamp.now()
Expand All @@ -634,7 +634,7 @@ def test_onOffset_deprecated(self, offset_types):
assert result == expected

def test_isAnchored_deprecated(self, offset_types):
# use idiomatic naming
# GH#30340 use idiomatic naming
off = self._get_offset(offset_types)

with tm.assert_produces_warning(FutureWarning):
Expand Down
2 changes: 1 addition & 1 deletion pandas/tseries/frequencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def get_offset(name: str) -> DateOffset:
"""
Return DateOffset object associated with rule name.

.. deprecated: 1.0.0
.. deprecated:: 1.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add here that to_offset should be used instead?

Examples
--------
Expand Down