PG-1710 Use temporary files instead of pipes for archive and restore commands #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (81.75%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #492 +/- ##
=====================================================
- Coverage 81.84% 81.75% -0.10%
=====================================================
Files 24 24
Lines 3002 2987 -15
Branches 490 485 -5
=====================================================
- Hits 2457 2442 -15
+ Misses 447 444 -3
- Partials 98 101 +3
🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
tde/archive-restore-tmpfiles
branch
2 times, most recently
from
f69a6dd to
27df780
Compare
|
There is a typo in the first commit message - usong -> using |
The error message did already include the path in the restore command so this was an oversight.
jeltz
force-pushed
the
tde/archive-restore-tmpfiles
branch
from
27df780 to
c81cb87
Compare
|
Fixed the typo and improved the commit message. |
jeltz
force-pushed
the
tde/archive-restore-tmpfiles
branch
from
3c54f5b to
a994c3b
Compare
artemgavrilov
approved these changes
Jul 30, 2025
…commands For some to me unknown reason pgbackrest archive-push did not like reading from a pipe so we create a temporary file instead. The location for the temporary file is for now hardcoded to be /dev/shm since that is guaranteed to be on a tmpfs mount on all common Linux distributions. We might in the future want to make this configurable since it is a Linux specific thing. I tested this with PgBackRest 2.55.0.
There is a cosntant used by PostgreSQL itself.
jeltz
force-pushed
the
tde/archive-restore-tmpfiles
branch
from
a994c3b to
6ecf0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some to me unknown reason
pgbackrest archive-pushdid not like reading from a pipe so we create a temporary file instead. The location for the temporary file is for now hardcoded to be/dev/shmsince that is guaranteed to be on a tmpfs mount on all common Linux distributions. We might in the future want to make this configurable since it is a Linux specific thing.I tested this with PgBackRest 2.55.0.