Skip to content

Fix bug #71041 dynamic embed SAPI load error#3670

Closed
VBart wants to merge 1 commit intophp:masterfrom
VBart:master
Closed

Fix bug #71041 dynamic embed SAPI load error#3670
VBart wants to merge 1 commit intophp:masterfrom
VBart:master

Conversation

@VBart
Copy link
Contributor

@VBart VBart commented Nov 20, 2018

If the library is built with ZEND_SIGNALS defined, it's unusable with an external SAPI module because the zend_signal_startup() call is mandatory in this case.

This bug is similar to #74149, but related to dynamic loading of PHP library.

https://bugs.php.net/bug.php?id=74149
https://bugs.php.net/bug.php?id=71041

If the library is built with ZEND_SIGNALS defined, it's unusable with an
external SAPI module because the zend_signal_startup() call is mandatory
in this case.

This bug is similar to #74149, but related to dynamic loading of PHP library.
@petk petk added the Bug label Nov 20, 2018
@nikic
Copy link
Member

nikic commented Nov 20, 2018

Merged as 11ddf76 into 7.1+. I've also added ZEND_API to the function definition, as we usually do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants