Skip to content

GH-137426: Remove code deprecation of importlib.abc.ResourceLoader #137567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Aug 8, 2025

Enough other classes in importlib.abc inherit from the class and the deprecation was to redirect people to TraversableResources. The documentation now makes it clear the class only exists for backwards compatibility.


📚 Documentation preview 📚: https://cpython-previews--137567.org.readthedocs.build/

…ader`

Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility.
@brettcannon
Copy link
Member Author

brettcannon commented Aug 8, 2025

Added @hugovk as a reviewer as I made #137426 a release blocker in case that made sense.

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the correct direction to me!

@brettcannon brettcannon merged commit 7140b99 into python:main Aug 11, 2025
42 checks passed
@brettcannon brettcannon deleted the 137426-undeprecate-ResourceLoader branch August 11, 2025 23:18
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2025
…ader` (pythonGH-137567)

Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility.

---------
(cherry picked from commit 7140b99)

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 11, 2025

GH-137654 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-importlib type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants