-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
GH-137426: Remove code deprecation of importlib.abc.ResourceLoader
#137567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-137426: Remove code deprecation of importlib.abc.ResourceLoader
#137567
Conversation
…ader` Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the correct direction to me!
Misc/NEWS.d/next/Library/2025-08-08-15-00-38.gh-issue-137426.lW-Rk2.rst
Outdated
Show resolved
Hide resolved
…W-Rk2.rst Co-authored-by: Hugo van Kemenade <[email protected]>
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ader` (pythonGH-137567) Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility. --------- (cherry picked from commit 7140b99) Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
GH-137654 is a backport of this pull request to the 3.14 branch. |
Enough other classes in
importlib.abc
inherit from the class and the deprecation was to redirect people toTraversableResources
. The documentation now makes it clear the class only exists for backwards compatibility.importlib.abc.SourceLoader
issuesDeprecationWarning
because it inherits fromResourceLoader
#137426📚 Documentation preview 📚: https://cpython-previews--137567.org.readthedocs.build/