gh-128042: configure complains when CFLAGS=-O0 and --enable-optimizations
#137975
Conversation
…ptimizations are set
taegyunkim
requested review from
erlend-aasland,
corona10 and
AA-Turner
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@AA-Turner Could you please take a look again? |
| # Check for conflicting CFLAGS=-O0 and --enable-optimizations | ||
| case "$CFLAGS" in | ||
| *-O0*) | ||
| AC_MSG_WARN([CFLAGS contains -O0 which may conflict with --enable-optimizations. Consider removing -O0 from CFLAGS for optimal performance.]) |
There was a problem hiding this comment.
line length
| AC_MSG_WARN([CFLAGS contains -O0 which may conflict with --enable-optimizations. Consider removing -O0 from CFLAGS for optimal performance.]) | |
| AC_MSG_WARN([CFLAGS contains -O0 which may conflict with \ | |
| --enable-optimizations. Consider removing -O0 from CFLAGS \ | |
| for optimal performance.]) |
Uh oh!
There was an error while loading. Please reload this page.