Skip to content

gh-128042: configure warns when CFLAGS=-O0 and --enable-optimizations #137975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 26, 2025
Merged

gh-128042: configure warns when CFLAGS=-O0 and --enable-optimizations #137975

merged 8 commits into from
Aug 26, 2025
+16 −0

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Aug 20, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Aug 20, 2025
Closed
This was referenced Aug 20, 2025
Closed
Closed
AA-Turner
AA-Turner requested changes Aug 20, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@taegyunkim
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2025

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from AA-Turner August 20, 2025 14:41
@python-cla-bot
Copy link

python-cla-bot bot commented Aug 20, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@taegyunkim
Copy link
Contributor Author

@AA-Turner Could you please take a look again?

AA-Turner
AA-Turner reviewed Aug 25, 2025
View reviewed changes
@taegyunkim @AA-Turner
Update configure.ac
69d1659 
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 26, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Aug 26, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@taegyunkim taegyunkim requested a review from AA-Turner August 26, 2025 20:00
@hauntsaninja
Copy link
Contributor

hauntsaninja commented Aug 26, 2025 •
edited
Loading

Since this is a change visible to users, could you add a news entry? The app https://blurb-it.herokuapp.com/ is useful for this

@taegyunkim taegyunkim changed the title gh-128042: configure complains when CFLAGS=-O0 and --enable-optimizations gh-128042: configure warns when CFLAGS=-O0 and --enable-optimizations Aug 26, 2025
@taegyunkim
Copy link
Contributor Author

taegyunkim commented Aug 26, 2025 •
edited
Loading

@hauntsaninja Done!
Could you remove skip news flag then?

hauntsaninja
hauntsaninja reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done! Hm I think Adam's line break suggestion causes this to get printed out with the whitespace mid sentence

@taegyunkim
Copy link
Contributor Author

taegyunkim commented Aug 26, 2025 •
edited
Loading

Updated to use m4_normalize and it looks as the following now
image

@AA-Turner
Copy link
Member

Thanks, done! Hm I think Adam's line break suggestion causes this to get printed out with the whitespace mid sentence

Oh, the joys of autoconf... Thanks for noticing!

A

hauntsaninja
hauntsaninja approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!! :-)

@AA-Turner AA-Turner merged commit ffaec6e into python:main Aug 26, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taegyunkim @hauntsaninja @AA-Turner