Skip to content

Enable all SIM rules except disabled ones #164645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable all SIM rules except disabled ones #164645

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8abf28b
Enable more SIM ruff checks
cyyever Oct 4, 2025
fe06c87
Fix errors
cyyever Oct 5, 2025
75c3b0c
Revert changes
cyyever Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert changes 
Signed-off-by: Yuanyuan Chen <[email protected]>
  • Loading branch information
@cyyever
cyyever committed Oct 10, 2025
commit 75c3b0c9d27a8b04ebcef4126a05b6465cb81e1c
3 changes: 2 additions & 1 deletion torch/distributed/optim/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def step(self, autograd_ctx_id: int):
all_local_grads = dist_autograd.get_gradients(autograd_ctx_id)
# apply functional optimizer step with a list of gradients
grads: list[Optional[Tensor]] = [
all_local_grads.get(p, None) for p in self._local_params
all_local_grads[p] if p in all_local_grads else None # noqa: SIM401
for p in self._local_params
]

self.optim.step(grads)
Expand Down
Loading